Fix NPM+puppeteer disconnect error handling

5 years ago · 8809ab6641
parent 43faa23551
commit 8809ab6641
1 changed files with 6 additions and 1 deletions
--- a/src/drivers/npm/browsers/puppeteer.js
+++ b/src/drivers/npm/browsers/puppeteer.js
@ -46,6 +46,7 @@ class PuppeteerBrowser extends Browser {
  }

  async visit(url) {
+    let done = false;
    let browser;

    try {
@ -55,7 +56,9 @@ class PuppeteerBrowser extends Browser {
    }

    browser.on('disconnected', () => {
+      if (!done) {
        throw new Error('Disconnected');
+      }
    });

    try {
@ -133,6 +136,8 @@ class PuppeteerBrowser extends Browser {
    } catch (error) {
      throw new Error(error.message || error.toString());
    } finally {
+      done = true;
+
      await browser.close();
    }
  }