Fix error handling in NPM/Puppeteer

src/drivers/npm/browsers/puppeteer.js

@@ -68,100 +68,106 @@ class PuppeteerBrowser extends Browser {
   }
 
   async visit(url) {
-    return new Promise(async (resolve, reject) => {
+    let done = false;
-      let done = false;
+    let browser;
-      let browser;
-
-      try {
-        browser = await this.browser();
-      } catch (error) {
-        reject(new Error(error.message || error.toString()));
-      }
 
-      browser.on('disconnected', () => {
+    try {
-        if (!done) {
+      await new Promise(async (resolve, reject) => {
-          reject(new Error('Disconnected'));
+        try {
+          browser = await this.browser();
+        } catch (error) {
+          return reject(error);
         }
-      });
 
-      try {
+        browser.on('disconnected', () => {
-        const page = await browser.newPage();
+          if (!done) {
+            reject(new Error('Disconnected'));
+          }
+        });
 
-        page.setDefaultTimeout(this.options.maxWait);
+        try {
+          const page = await browser.newPage();
 
-        await page.setRequestInterception(true);
+          page.setDefaultTimeout(this.options.maxWait);
 
-        page.on('error', reject);
+          await page.setRequestInterception(true);
 
-        page.on('request', request => request.continue());
+          page.on('error', reject);
 
-        page.on('response', (response) => {
+          page.on('request', request => request.continue());
-          if (response.status() === 301 || response.status() === 302) {
-            return;
-          }
 
-          if (!this.statusCode) {
+          page.on('response', (response) => {
-            this.statusCode = response.status();
+            if (response.status() === 301 || response.status() === 302) {
+              return;
+            }
 
-            this.headers = {};
+            if (!this.statusCode) {
+              this.statusCode = response.status();
 
-            const headers = response.headers();
+              this.headers = {};
 
-            Object.keys(headers).forEach((key) => {
+              const headers = response.headers();
-              this.headers[key] = Array.isArray(headers[key]) ? headers[key] : [headers[key]];
-            });
 
-            this.contentType = headers['content-type'] || null;
+              Object.keys(headers).forEach((key) => {
-          }
+                this.headers[key] = Array.isArray(headers[key]) ? headers[key] : [headers[key]];
-        });
+              });
 
-        page.on('console', ({ _type, _text, _location }) => this.log(`${_text} (${_location.url}: ${_location.lineNumber})`, _type));
+              this.contentType = headers['content-type'] || null;
+            }
+          });
 
-        await page.setUserAgent(this.options.userAgent);
+          page.on('console', ({ _type, _text, _location }) => this.log(`${_text} (${_location.url}: ${_location.lineNumber})`, _type));
 
-        await Promise.race([
+          await page.setUserAgent(this.options.userAgent);
-          page.goto(url, { waitUntil: 'networkidle2' }),
-          new Promise(_resolve => setTimeout(_resolve, this.options.maxWait)),
-        ]);
 
-        // eslint-disable-next-line no-undef
+          await Promise.race([
-        const links = await page.evaluateHandle(() => Array.from(document.getElementsByTagName('a')).map(({
+            page.goto(url, { waitUntil: 'networkidle2' }),
-          hash, hostname, href, pathname, protocol, rel,
+            new Promise(_resolve => setTimeout(_resolve, this.options.maxWait)),
-        }) => ({
+          ]);
-          hash,
-          hostname,
-          href,
-          pathname,
-          protocol,
-          rel,
-        })));
 
-        this.links = await links.jsonValue();
+          // eslint-disable-next-line no-undef
+          const links = await page.evaluateHandle(() => Array.from(document.getElementsByTagName('a')).map(({
+            hash, hostname, href, pathname, protocol, rel,
+          }) => ({
+            hash,
+            hostname,
+            href,
+            pathname,
+            protocol,
+            rel,
+          })));
 
-        // eslint-disable-next-line no-undef
+          this.links = await links.jsonValue();
-        const scripts = await page.evaluateHandle(() => Array.from(document.getElementsByTagName('script')).map(({
-          src,
-        }) => src));
 
-        this.scripts = (await scripts.jsonValue()).filter(script => script);
+          // eslint-disable-next-line no-undef
+          const scripts = await page.evaluateHandle(() => Array.from(document.getElementsByTagName('script')).map(({
+            src,
+          }) => src));
 
-        this.js = await page.evaluate(getJs);
+          this.scripts = (await scripts.jsonValue()).filter(script => script);
 
-        this.cookies = (await page.cookies()).map(({
+          this.js = await page.evaluate(getJs);
-          name, value, domain, path,
-        }) => ({
-          name, value, domain, path,
-        }));
 
-        this.html = await page.content();
+          this.cookies = (await page.cookies()).map(({
-      } catch (error) {
+            name, value, domain, path,
-        reject(error.message || error.toString());
+          }) => ({
-      } finally {
+            name, value, domain, path,
-        done = true;
+          }));
 
-        await browser.close();
+          this.html = await page.content();
-      }
+        } catch (error) {
-    });
+          return reject(error);
+        }
+
+        return resolve();
+      });
+    } catch (error) {
+      throw new Error(error.message || error.toString());
+    } finally {
+      done = true;
+
+      await browser.close();
+    }
   }
 }
 

src/drivers/npm/package.json

@@ -2,7 +2,7 @@
   "name": "wappalyzer",
   "description": "Uncovers the technologies used on websites",
   "homepage": "https://github.com/AliasIO/Wappalyzer",
-  "version": "5.9.13",
+  "version": "5.9.16",
   "author": "Elbert Alias",
   "license": "GPL-3.0",
   "repository": {