From 5598c4bdf3bceb85dbbb892a2c8d7bc4143fe05a Mon Sep 17 00:00:00 2001 From: Vasile FLorin Vilsan Date: Wed, 30 Jan 2019 07:58:00 +0000 Subject: [PATCH 1/7] added Rocket to apps.json --- src/apps.json | 20 ++++++++++++++++++++ src/icons/Rocket.svg | 27 +++++++++++++++++++++++++++ 2 files changed, 47 insertions(+) create mode 100644 src/icons/Rocket.svg diff --git a/src/apps.json b/src/apps.json index b6662c0fe..9f458999a 100644 --- a/src/apps.json +++ b/src/apps.json @@ -12921,6 +12921,26 @@ "implies": "Java", "script": "/halo-(?:backend|frontend|common)/", "website": "https://github.com/ruibaby/halo" + }, + "Rocket": { + "cats": [ + 1, + 6 + ], + "meta": { + "_csrf": "" + }, + "cookies": { + "PHPSESSID": "" + }, + "html": [ + "", + "" + ], + "icon": "Rocket.svg", + "implies": ["React","PHP", "Bootstrap", "webpack", "Node.js", "MySQL", "Apache", "jQuery", "Moment.js", "Less"], + "script": "/dist/frontend-(.+)\\.js", + "website": "https://rocketcms.io" } }, "categories": { diff --git a/src/icons/Rocket.svg b/src/icons/Rocket.svg new file mode 100644 index 000000000..feadcf82b --- /dev/null +++ b/src/icons/Rocket.svg @@ -0,0 +1,27 @@ + + + + + + + + + + From 3e166b69e68d5f61abf6ccd0a55839e17e3672e4 Mon Sep 17 00:00:00 2001 From: Vasile FLorin Vilsan Date: Thu, 31 Jan 2019 06:09:23 +0000 Subject: [PATCH 2/7] Updated RegEx to include non-capturing group as per Travis CI logs --- src/apps.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps.json b/src/apps.json index 9f458999a..292a8a8a8 100644 --- a/src/apps.json +++ b/src/apps.json @@ -12934,7 +12934,7 @@ "PHPSESSID": "" }, "html": [ - "", + "", "" ], "icon": "Rocket.svg", From c8e031db1ab75cfac274b53d61b0cac7318aadf2 Mon Sep 17 00:00:00 2001 From: Vasile FLorin Vilsan Date: Thu, 31 Jan 2019 06:30:46 +0000 Subject: [PATCH 3/7] Refactored usage of non-capturing group as recommended by Travis CI logs --- src/apps.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps.json b/src/apps.json index 292a8a8a8..cf3d75591 100644 --- a/src/apps.json +++ b/src/apps.json @@ -12934,7 +12934,7 @@ "PHPSESSID": "" }, "html": [ - "", + "", "" ], "icon": "Rocket.svg", From a91a1a5feeea7948c061c37a42be442f8d8ef5ce Mon Sep 17 00:00:00 2001 From: Vasile FLorin Vilsan Date: Thu, 31 Jan 2019 06:35:45 +0000 Subject: [PATCH 4/7] Refactored second capturing group as recommended by Travis CI logs --- src/apps.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps.json b/src/apps.json index cf3d75591..9aa78475f 100644 --- a/src/apps.json +++ b/src/apps.json @@ -12939,7 +12939,7 @@ ], "icon": "Rocket.svg", "implies": ["React","PHP", "Bootstrap", "webpack", "Node.js", "MySQL", "Apache", "jQuery", "Moment.js", "Less"], - "script": "/dist/frontend-(.+)\\.js", + "script": "/dist/frontend-[^\\.]+\\.js", "website": "https://rocketcms.io" } }, From eb33a1fbb27e9c4b888c21cf11984e6587987501 Mon Sep 17 00:00:00 2001 From: Vasile FLorin Vilsan Date: Sun, 3 Feb 2019 09:09:13 +0000 Subject: [PATCH 5/7] PR requests resolution --- src/apps.json | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/apps.json b/src/apps.json index 9aa78475f..e2d3369b6 100644 --- a/src/apps.json +++ b/src/apps.json @@ -12930,16 +12930,8 @@ "meta": { "_csrf": "" }, - "cookies": { - "PHPSESSID": "" - }, - "html": [ - "", - "" - ], "icon": "Rocket.svg", - "implies": ["React","PHP", "Bootstrap", "webpack", "Node.js", "MySQL", "Apache", "jQuery", "Moment.js", "Less"], - "script": "/dist/frontend-[^\\.]+\\.js", + "implies": ["webpack", "Node.js", "MySQL", "Less"], "website": "https://rocketcms.io" } }, From ecd0387fda3edd45ce4642dd36365781ebae3adf Mon Sep 17 00:00:00 2001 From: Vasile FLorin Vilsan Date: Sun, 3 Feb 2019 13:40:12 +0000 Subject: [PATCH 6/7] Second resolution round of PR requested changes --- src/apps.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/apps.json b/src/apps.json index e2d3369b6..080771e69 100644 --- a/src/apps.json +++ b/src/apps.json @@ -12927,8 +12927,8 @@ 1, 6 ], - "meta": { - "_csrf": "" + "headers": { + "x-powered-by": "Rocket=https://rocketcms.io/" }, "icon": "Rocket.svg", "implies": ["webpack", "Node.js", "MySQL", "Less"], From 3415e51231ad23c907965936ee4739ce4658368a Mon Sep 17 00:00:00 2001 From: Vasile FLorin Vilsan Date: Sun, 3 Feb 2019 13:51:13 +0000 Subject: [PATCH 7/7] modified header as requested --- src/apps.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps.json b/src/apps.json index 080771e69..8c443e6bb 100644 --- a/src/apps.json +++ b/src/apps.json @@ -12928,7 +12928,7 @@ 6 ], "headers": { - "x-powered-by": "Rocket=https://rocketcms.io/" + "x-powered-by": "^Rocket=https://rocketcms.io/" }, "icon": "Rocket.svg", "implies": ["webpack", "Node.js", "MySQL", "Less"],